dongjoon-hyun commented on a change in pull request #28956:
URL: https://github.com/apache/spark/pull/28956#discussion_r448110859
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -408,19 +407,66 @@ abstract class NumberToTimestampBase extends
UnaryExpression
}
}
+// scalastyle:off line.size.limit
@ExpressionDescription(
- usage = "_FUNC_(seconds) - Creates timestamp from the number of seconds
since UTC epoch.",
+ usage = "_FUNC_(seconds) - Creates timestamp from the number of seconds (can
be fractional) since UTC epoch.",
examples = """
Examples:
> SELECT _FUNC_(1230219000);
2008-12-25 07:30:00
+ > SELECT _FUNC_(1230219000.123);
+ 2008-12-25 07:30:00.123
""",
group = "datetime_funcs",
since = "3.1.0")
-case class SecondsToTimestamp(child: Expression)
- extends NumberToTimestampBase {
+// scalastyle:on line.size.limit
+case class SecondsToTimestamp(child: Expression) extends UnaryExpression
+ with ExpectsInputTypes with NullIntolerant{
Review comment:
nit: `NullIntolerant{` -> `NullIntolerant {`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
