dongjoon-hyun commented on a change in pull request #28956:
URL: https://github.com/apache/spark/pull/28956#discussion_r448114383
##########
File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
##########
@@ -2,13 +2,16 @@
-- [SPARK-31710] TIMESTAMP_SECONDS, TIMESTAMP_MILLISECONDS and
TIMESTAMP_MICROSECONDS to timestamp transfer
select
TIMESTAMP_SECONDS(1230219000),TIMESTAMP_SECONDS(-1230219000),TIMESTAMP_SECONDS(null);
+select TIMESTAMP_SECONDS(1.23), TIMESTAMP_SECONDS(1.23d);
Review comment:
Since this has `Decimal` and `Double`, can we have `Float` together by
using `TIMESTAMP_SECONDS(CAST(1.23 AS FLOAT))`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
