Github user achanda commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5115#discussion_r27002784
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -792,6 +793,11 @@ private[spark] object Utils extends Logging {
       lazy val localIpAddress: String = findLocalIpAddress()
       lazy val localIpAddressHostname: String = 
getAddressHostName(localIpAddress)
     
    +  def localIpURI(): String = {
    --- End diff --
    
    `toUriString` takes in an `InetAddress`. If I do the formatting at the 
caller, I'd need to copy paste two lines of code in two places. I was hoping to 
avoid that by putting it in Utils. However, in the last patch, I did miss some 
logic around handling env variables. Working on that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to