Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5115#discussion_r27474075
  
    --- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
    @@ -160,7 +163,7 @@ private[spark] class HttpServer(
           throw new ServerStateException("Server is not started")
         } else {
           val scheme = if (securityManager.fileServerSSLOptions.enabled) 
"https" else "http"
    -      s"$scheme://${Utils.localIpAddress}:$port"
    +      
s"$scheme://${InetAddresses.toUriString(InetAddress.getByName(Utils.localIpAddress))}:$port"
    --- End diff --
    
    This is a complex enough expression that it should just be a local val. 
Also, in the other file, the `java.net.InetAddress` import should sort above 
scala imports. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to