cloud-fan commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r448397649
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/ComplexTypes.scala
##########
@@ -39,7 +41,15 @@ object SimplifyExtractValueOps extends Rule[LogicalPlan] {
// Remove redundant field extraction.
case GetStructField(createNamedStruct: CreateNamedStruct, ordinal, _) =>
createNamedStruct.valExprs(ordinal)
-
+ case GetStructField(w@WithFields(struct, names, valExprs), ordinal,
maybeGetFieldName) =>
+ val getFieldName =
maybeGetFieldName.getOrElse(w.dataType(ordinal).name)
Review comment:
I think it's better to use `w.dataType(ordinal).name` only, then we can
write `names.zip(valExprs).filter(_._1 == fieldName)` to find the match.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
