cloud-fan commented on a change in pull request #27066:
URL: https://github.com/apache/spark/pull/27066#discussion_r448398458
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -235,7 +237,8 @@ abstract class Optimizer(catalogManager: CatalogManager)
PullupCorrelatedPredicates.ruleName ::
RewriteCorrelatedScalarSubquery.ruleName ::
RewritePredicateSubquery.ruleName ::
- NormalizeFloatingNumbers.ruleName :: Nil
+ NormalizeFloatingNumbers.ruleName ::
+ CombineWithFields.ruleName :: Nil
Review comment:
This is an optimization and doesn't affect correctness. We should not
treat it as `nonExcludableRules`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
