warrenzhu25 commented on a change in pull request #28942:
URL: https://github.com/apache/spark/pull/28942#discussion_r448485813
##########
File path:
core/src/main/scala/org/apache/spark/status/api/v1/StagesResource.scala
##########
@@ -96,8 +96,9 @@ private[v1] class StagesResource extends BaseAppResource {
@PathParam("stageAttemptId") stageAttemptId: Int,
@DefaultValue("0") @QueryParam("offset") offset: Int,
@DefaultValue("20") @QueryParam("length") length: Int,
- @DefaultValue("ID") @QueryParam("sortBy") sortBy: TaskSorting):
Seq[TaskData] = {
- withUI(_.store.taskList(stageId, stageAttemptId, offset, length, sortBy))
+ @DefaultValue("ID") @QueryParam("sortBy") sortBy: TaskSorting,
+ @QueryParam("status") statuses: JList[TaskStatus]): Seq[TaskData] = {
Review comment:
Ok, I'm also considering using `TaskStatus`. The reason I use JList is
to make it consistent with stageList as below:
```
@GET
def stageList(@QueryParam("status") statuses: JList[StageStatus]):
Seq[StageData] = {
withUI(_.store.stageList(statuses))
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
