dongjoon-hyun commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r450557488



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2106,6 +2106,15 @@ object SQLConf {
       .booleanConf
       .createWithDefault(true)
 
+  val OPTIMIZER_IGNORE_HINTS =
+    buildConf("spark.sql.optimizer.ignoreHints")

Review comment:
       For that, I'm not sure either. That's the reason why I pinged @cloud-fan 
to get his advice.
   
   BTW, I'm okay for both `spark.sql.optimizer.xxx` or `spark.sql.xxx`. As I 
replied in a different comment, I asked to change only the variable name `val 
OPTIMIZER_IGNORE_HINTS`. Since there was no other comment about the 
configuration name, I guessed `spark.sql.optimizer.xxx` was our concensus.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to