cloud-fan commented on a change in pull request #28983:
URL: https://github.com/apache/spark/pull/28983#discussion_r450874248



##########
File path: 
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/UDAQuerySuite.scala
##########
@@ -119,6 +119,15 @@ object CountSerDeAgg extends Aggregator[Int, 
CountSerDeSQL, CountSerDeSQL] {
   def outputEncoder: Encoder[CountSerDeSQL] = 
ExpressionEncoder[CountSerDeSQL]()
 }
 
+object ArrayDataAgg extends Aggregator[Array[Double], Double, Double] {

Review comment:
       can we test if the buffer is array type as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to