HyukjinKwon commented on a change in pull request #29023:
URL: https://github.com/apache/spark/pull/29023#discussion_r451899227
##########
File path: python/pyspark/rdd.py
##########
@@ -141,7 +141,9 @@ def _parse_memory(s):
def _load_from_socket(sock_info, serializer):
- (sockfile, sock) = local_connect_and_auth(*sock_info)
+ port = sock_info[0]
+ auth_secret = sock_info[1]
+ (sockfile, sock) = local_connect_and_auth(port, auth_secret)
Review comment:
Yeah, I actually already pointed it out it's error-prone. Feel free to
open another PR to fix it.
##########
File path: python/pyspark/rdd.py
##########
@@ -141,7 +141,9 @@ def _parse_memory(s):
def _load_from_socket(sock_info, serializer):
- (sockfile, sock) = local_connect_and_auth(*sock_info)
+ port = sock_info[0]
+ auth_secret = sock_info[1]
+ (sockfile, sock) = local_connect_and_auth(port, auth_secret)
Review comment:
Yeah, I actually already pointed it out it's error-prone in the previous
PR. Feel free to open another PR to fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
