maropu commented on a change in pull request #29024: URL: https://github.com/apache/spark/pull/29024#discussion_r451901435
########## File path: core/src/main/scala/org/apache/spark/security/SecurityConfigurationLock.scala ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.security + +import org.apache.spark.annotation.DeveloperApi + +/** + * ::DeveloperApi:: + * There are cases when global JVM security configuration must be modified. + * In order to avoid race the modification must be synchronized with this. + */ +@DeveloperApi +object SecurityConfigurationLock Review comment: I think its annoying to make 3rd-party developers care about this lock. Could we have the synchronization in the caller side, e.g., `ConnectionProvider.create`? ########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ########## @@ -23,12 +23,15 @@ import java.util.{Locale, Properties} import org.apache.commons.io.FilenameUtils import org.apache.spark.SparkFiles +import org.apache.spark.annotation.DeveloperApi import org.apache.spark.internal.Logging import org.apache.spark.sql.catalyst.util.CaseInsensitiveMap /** + * ::DeveloperApi:: * Options for the JDBC data source. */ +@DeveloperApi Review comment: This is an internal class, so could you avoid exposing it? How about using `Map[String, String]` instead in the provider? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
