cloud-fan commented on a change in pull request #28924:
URL: https://github.com/apache/spark/pull/28924#discussion_r452076697
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
##########
@@ -142,8 +143,8 @@ class BlockManagerMaster(
logWarning(s"Failed to remove RDD $rddId - ${e.getMessage}", e)
)(ThreadUtils.sameThread)
if (blocking) {
- timeout.awaitResult(future)
- }
+ // the underlying Futures will timeout anyway, so it's safe to use
infinite here
+ infinite.awaitResult(future) }
Review comment:
nit: code styl
```
if (blocking) {
infinite.awaitResult(future)
}
```
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMaster.scala
##########
@@ -142,8 +143,8 @@ class BlockManagerMaster(
logWarning(s"Failed to remove RDD $rddId - ${e.getMessage}", e)
)(ThreadUtils.sameThread)
if (blocking) {
- timeout.awaitResult(future)
- }
+ // the underlying Futures will timeout anyway, so it's safe to use
infinite here
+ infinite.awaitResult(future) }
Review comment:
nit: code style
```
if (blocking) {
infinite.awaitResult(future)
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
