cloud-fan commented on a change in pull request #28924:
URL: https://github.com/apache/spark/pull/28924#discussion_r452163195
##########
File path: core/src/main/scala/org/apache/spark/util/RpcUtils.scala
##########
@@ -54,6 +56,14 @@ private[spark] object RpcUtils {
RpcTimeout(conf, Seq(RPC_LOOKUP_TIMEOUT.key, NETWORK_TIMEOUT.key), "120s")
}
+ /**
+ * Infinite timeout is used internally, so there's no timeout configuration
property that
+ * controls it. Therefore, we use "infinite" without any specific reason as
its timeout
+ * configuration property. And its timeout property should never be accessed
since infinite
+ * means we never timeout.
+ */
+ val infiniteTimeout = new RpcTimeout(Long.MaxValue.nanos, "infinite")
Review comment:
shall we upper case the name as it's a constant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
