imback82 commented on a change in pull request #28676:
URL: https://github.com/apache/spark/pull/28676#discussion_r452582845
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -51,7 +53,7 @@ case class BroadcastHashJoinExec(
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of output
rows"))
override def requiredChildDistribution: Seq[Distribution] = {
- val mode = HashedRelationBroadcastMode(buildKeys)
+ val mode = HashedRelationBroadcastMode(buildBoundKeys)
Review comment:
Because this `mode` is passed to `BroadcastExchangeExec` and eventually
used to create `UnsafeProjection`. Btw, this is an existing code, but renamed
per [this
discussion](https://github.com/apache/spark/pull/28676#discussion_r448124006).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
