HyukjinKwon commented on a change in pull request #27908:
URL: https://github.com/apache/spark/pull/27908#discussion_r452582926



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala
##########
@@ -313,6 +313,22 @@ class CatalogImpl(sparkSession: SparkSession) extends 
Catalog {
     createTable(tableName, source, new StructType, options)
   }
 
+  /**
+   * (Scala-specific)
+   * Creates a table based on the dataset in a data source and a set of 
options.
+   * Then, returns the corresponding DataFrame.
+   *
+   * @group ddl_ops
+   * @since 3.1.0
+   */
+  override def createTable(
+      tableName: String,
+      source: String,
+      options: Map[String, String],
+      description: Option[String]): DataFrame = {

Review comment:
       Oh yeah, we shouldn't use `Option` because this is a Scala specific 
collection. We will just have to override so Java side can call these as well.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to