dongjoon-hyun commented on a change in pull request #29045:
URL: https://github.com/apache/spark/pull/29045#discussion_r453335630
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
##########
@@ -185,10 +185,15 @@ class OrcFileFormat
isCaseSensitive, dataSchema, requiredSchema, reader, conf)
}
- if (requestedColIdsOrEmptyFile.isEmpty) {
+ if (requestedColIdsOrEmptyFile._2) {
+ resultSchemaString = OrcUtils.orcTypeDescriptionString(actualSchema)
+ }
+ OrcConf.MAPRED_INPUT_SCHEMA.setString(conf, resultSchemaString)
+
+ if (requestedColIdsOrEmptyFile._1.isEmpty) {
Review comment:
Thank you for updating, @SaurabhChawla100 . However, `_1` and `_2` is
not good in general. You may try like the following at line 182.
```scala
- val requestedColIdsOrEmptyFile =
+ val (requestedColIdsOrEmptyFile, sendActualSchema) =
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
