dongjoon-hyun commented on a change in pull request #29045:
URL: https://github.com/apache/spark/pull/29045#discussion_r453335860
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/orc/HiveOrcQuerySuite.scala
##########
@@ -288,4 +288,56 @@ class HiveOrcQuerySuite extends OrcQueryTest with
TestHiveSingleton {
}
}
}
+
+ test("SPARK-32234: orc data created by the hive tables having _col fields" +
+ " name for vectorized reader") {
+ Seq(false, true).foreach { vectorized =>
+ withSQLConf(SQLConf.ORC_VECTORIZED_READER_ENABLED.key ->
vectorized.toString) {
+ withTable("test_hive_orc_vect_read") {
+ spark.sql(
+ """
+ | CREATE TABLE test_hive_orc_vect_read
+ | (_col1 INT, _col2 STRING, _col3 INT)
+ | USING orc
+ """.stripMargin)
+ spark.sql(
+ """
+ | INSERT INTO
+ | test_hive_orc_vect_read
+ | VALUES(9, '12', 2020)
+ """.stripMargin)
+
+ val df = spark.sql("SELECT _col2 FROM test_hive_orc_vect_read")
+ checkAnswer(df, Row("12"))
+ }
+ }
+ }
+ }
+
+ test("SPARK-32234: orc data created by the hive tables having _col fields
name" +
Review comment:
Please merge two test cases like the following in order to have a full
test coverage in all combinations.
```scala
Seq("native", "hive").foreach { orcImpl =>
Seq(false, true).foreach { vectorized =>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
