viirya commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r453366149
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -116,6 +116,15 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
case CreateMap(children, useStringTypeWhenEmpty) =>
CreateMap(children.map(normalize), useStringTypeWhenEmpty)
+ case If(cond, trueValue, falseValue) =>
Review comment:
Based on the doc of `NormalizeFloatingNumbers`, we handle that well
during comparison. So the boolean condition is okay. We need normalize
`trueValue` and `falseValue` because they could be passed through up to binary
format in grouping/join/window partition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
