viirya commented on a change in pull request #29061:
URL: https://github.com/apache/spark/pull/29061#discussion_r453368110
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala
##########
@@ -116,6 +116,15 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
case CreateMap(children, useStringTypeWhenEmpty) =>
CreateMap(children.map(normalize), useStringTypeWhenEmpty)
+ case If(cond, trueValue, falseValue) =>
Review comment:
I think we only need to have normalization on `trueValue3` and
`falseValue3`, as they are the only results passing through the top-level `If`.
The inner `If`s are evaluated during executing the top-level `If`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
