AngersZhuuuu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r456200197
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##########
@@ -87,17 +131,55 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
}
}
}
+
+ private lazy val fieldWriters: Seq[String => Any] = output.map { attr =>
+ val converter =
CatalystTypeConverters.createToCatalystConverter(attr.dataType)
+ attr.dataType match {
+ case StringType => (data: String) => converter(data)
+ case ByteType => (data: String) =>
converter(JavaUtils.stringToBytes(data))
Review comment:
> Why did you convert a string into a byte array for byte types?
Oh sorry for my mistake, changed and add this type check in UT
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
