AngersZhuuuu commented on a change in pull request #29085:
URL: https://github.com/apache/spark/pull/29085#discussion_r456309141
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/BaseScriptTransformationExec.scala
##########
@@ -87,17 +131,55 @@ trait BaseScriptTransformationExec extends UnaryExecNode {
}
}
}
+
+ private lazy val fieldWriters: Seq[String => Any] = output.map { attr =>
+ val converter =
CatalystTypeConverters.createToCatalystConverter(attr.dataType)
+ attr.dataType match {
+ case StringType => (data: String) => converter(data)
+ case ByteType => (data: String) => converter(data.toByte)
+ case IntegerType => (data: String) => converter(data.toInt)
+ case ShortType => (data: String) => converter(data.toShort)
+ case LongType => (data: String) => converter(data.toLong)
+ case FloatType => (data: String) => converter(data.toFloat)
+ case DoubleType => (data: String) => converter(data.toDouble)
+ case dt: DecimalType => (data: String) => converter(BigDecimal(data))
+ case DateType if conf.datetimeJava8ApiEnabled => (data: String) =>
Review comment:
Yea, update later, and How to decide to use which serde or default
serde, I think it's better to decide in alfozan's pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
