Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5210#discussion_r27250110
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -435,11 +435,18 @@ private[sql] case class ParquetRelation2(
// Push down filters when possible. Notice that not all filters can be
converted to Parquet
// filter predicate. Here we try to convert each individual predicate
and only collect those
// convertible ones.
- predicates
- .flatMap(ParquetFilters.createFilter)
- .reduceOption(FilterApi.and)
- .filter(_ => sqlContext.conf.parquetFilterPushDown)
- .foreach(ParquetInputFormat.setFilterPredicate(jobConf, _))
+ if (sqlContext.conf.parquetFilterPushDown) {
+ predicates
+ // Don't push down predicates which reference partition columns
+ .filter { pred =>
+ val partitionColNames = partitionColumns.map(_.name).toSet
+ val referencedColNames = pred.references.map(_.name).toSet
+ referencedColNames.intersect(partitionColNames).isEmpty
+ }
+ .flatMap(ParquetFilters.createFilter)
--- End diff --
This is a pretty common construct throughout the query planner, but we can
certainly add comments.
Its essentially take any filters that we can convert a parquet filter
(skipping those that parquet does not support), and `And` them together into a
single predicate. Set that in the job conf, or do nothing if no filters can be
converted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
