Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/5210#discussion_r27252832
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/parquet/newParquet.scala ---
@@ -435,11 +435,18 @@ private[sql] case class ParquetRelation2(
// Push down filters when possible. Notice that not all filters can be
converted to Parquet
// filter predicate. Here we try to convert each individual predicate
and only collect those
// convertible ones.
- predicates
- .flatMap(ParquetFilters.createFilter)
- .reduceOption(FilterApi.and)
- .filter(_ => sqlContext.conf.parquetFilterPushDown)
- .foreach(ParquetInputFormat.setFilterPredicate(jobConf, _))
+ if (sqlContext.conf.parquetFilterPushDown) {
+ predicates
+ // Don't push down predicates which reference partition columns
+ .filter { pred =>
+ val partitionColNames = partitionColumns.map(_.name).toSet
+ val referencedColNames = pred.references.map(_.name).toSet
+ referencedColNames.intersect(partitionColNames).isEmpty
+ }
+ .flatMap(ParquetFilters.createFilter)
--- End diff --
Yeah reynold's one seems more clear to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
