HeartSaVioR commented on a change in pull request #29149:
URL: https://github.com/apache/spark/pull/29149#discussion_r456733337
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/HybridStore.scala
##########
@@ -144,10 +146,9 @@ private[history] class HybridStore extends KVStore {
backgroundThread = new Thread(() => {
try {
for (klass <- klassMap.keys().asScala) {
- val it = inMemoryStore.view(klass).closeableIterator()
- while (it.hasNext()) {
- levelDB.write(it.next())
- }
+ val values = Lists.newArrayList(
Review comment:
This would be OK, given all entries are from inMemoryStore which are
already materialized into memory.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
