baohe-zhang commented on a change in pull request #29149:
URL: https://github.com/apache/spark/pull/29149#discussion_r456851608
##########
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java
##########
@@ -171,6 +172,58 @@ public void write(Object value) throws Exception {
}
}
+ public void writeAll(List<?> values) throws Exception {
+ Preconditions.checkArgument(values != null && !values.isEmpty(),
+ "Non-empty values required.");
+
+ // Group by class, in case there are values from different classes in the
values
+ // Typical usecase is for this to be a single class.
+ // A NullPointerException will be thrown if values contain null object.
+ for (Map.Entry<? extends Class<?>, ? extends List<?>> entry :
+
values.stream().collect(Collectors.groupingBy(Object::getClass)).entrySet()) {
+
+ final Iterator<?> valueIter = entry.getValue().iterator();
+ final Iterator<byte[]> serializedValueIter;
+
+ // Deserialize outside synchronized block
+ List<byte[]> list = new ArrayList<>(entry.getValue().size());
+ for (Object value : values) {
+ list.add(serializer.serialize(value));
+ }
+ serializedValueIter = list.iterator();
+
+ final Class<?> klass = entry.getKey();
+ final LevelDBTypeInfo ti = getTypeInfo(klass);
+
+ synchronized (ti) {
+ final LevelDBTypeInfo.Index naturalIndex = ti.naturalIndex();
+ final Collection<LevelDBTypeInfo.Index> indices = ti.indices();
+
+ try (WriteBatch batch = db().createWriteBatch()) {
+ while (valueIter.hasNext()) {
+ final Object value = valueIter.next();
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
