Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5223#issuecomment-86928639
I like the idea. What I slightly don't like is making a utility method but
then using it to solve just one instance of the issue. I think that this
doesn't need to apply to all `finally` blocks, but just ones like this
situation, where it's likely that a knock-on exception could hide the useful
original one. Could you survey the codebase and see if there are other
instances that could benefit from this treatment? I think it's a good
improvement.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
