Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5223#issuecomment-87399536
Grepping for something coarse like `out.*\.close\(` found about 30
potential instances. Unfortunately a lot of them have a slightly more
significant problem: they don't even `close()` in a `finally` block. No
exception masking, but, also no cleanup on the error path.
In many of the cases (tests, utility helper code) it probably doesn't
matter but some of them look worth fixing with this nice utility method, that
gets both the `finally` and exception masking situation right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
