viirya commented on a change in pull request #29107:
URL: https://github.com/apache/spark/pull/29107#discussion_r458909616
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -1387,7 +1388,7 @@ class Analyzer(
i.copy(right = dedupRight(left, right))
case e @ Except(left, right, _) if !e.duplicateResolved =>
e.copy(right = dedupRight(left, right))
- case u @ Union(children) if !u.duplicateResolved =>
+ case u @ Union(children, _, _) if !u.duplicateResolved =>
Review comment:
`duplicateResolved` checks attribute sets from children that look at
`exprId` actually. By-name resolution is only for attribute name. If you think
it is safer, I can add it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
