viirya commented on a change in pull request #29107:
URL: https://github.com/apache/spark/pull/29107#discussion_r458922812
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -337,6 +337,10 @@ trait CheckAnalysis extends PredicateHelper {
case Tail(limitExpr, _) => checkLimitLikeClause("tail", limitExpr)
+ case Union(_, byName, allowMissingCol) if byName || allowMissingCol
=>
+ failAnalysis("Union should not be with true `byName` or " +
Review comment:
I add `!(byName || allowMissingCol)` to the condition at
`Union.resolved` now. Then do we still need to check them at `CheckAnalysis`
like above? Or just follow other nodes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
