leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r459788703
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -453,6 +494,47 @@ case class BroadcastHashJoinExec(
val (keyEv, anyNull) = genStreamSideJoinKey(ctx, input)
val (matched, checkCondition, _) = getJoinCondition(ctx, input)
val numOutput = metricTerm(ctx, "numOutputRows")
+ val isLongHashedRelation =
broadcastRelation.value.isInstanceOf[LongHashedRelation]
+
+ // fast stop if isOriginInputEmpty = true
+ // whether isNullAwareAntiJoin is true or false
+ // should accept all rows in streamedSide
+ if (broadcastRelation.value.isOriginInputEmpty) {
+ return s"""
+ |// Common Anti Join isOriginInputEmpty(true) accept all
+ |$numOutput.add(1);
+ |${consume(ctx, input)}
+ """.stripMargin
+ }
+
+ if (isNullAwareAntiJoin) {
+ if (broadcastRelation.value.allNullColumnKeyExistsInOriginInput) {
+ return s"""
+ |// NAAJ isOriginInputEmpty(false) anyNullKeyExists(true)
reject all
Review comment:
the for loop is generated in parent codegen support operator.
if we adopt "${consume(ctx, input)}" means this row is adopted and placed
into downstream operator.
if we want to reject all column it's as simple as just putting a empty
string in BHJ scope gen code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
