leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r459795966
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -453,6 +494,47 @@ case class BroadcastHashJoinExec(
val (keyEv, anyNull) = genStreamSideJoinKey(ctx, input)
val (matched, checkCondition, _) = getJoinCondition(ctx, input)
val numOutput = metricTerm(ctx, "numOutputRows")
+ val isLongHashedRelation =
broadcastRelation.value.isInstanceOf[LongHashedRelation]
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -96,7 +122,8 @@ private[execution] object HashedRelation {
input: Iterator[InternalRow],
key: Seq[Expression],
sizeEstimate: Int = 64,
- taskMemoryManager: TaskMemoryManager = null): HashedRelation = {
+ taskMemoryManager: TaskMemoryManager = null,
+ isNullAware: Boolean = false): HashedRelation = {
Review comment:
done
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -323,11 +371,19 @@ private[joins] object UnsafeHashedRelation {
// Create a mapping of buildKeys -> rows
val keyGenerator = UnsafeProjection.create(key)
var numFields = 0
+ val numKeys = key.length
+ val isOriginInputEmpty = !input.hasNext
+ var allNullColumnKeyExistsInOriginInput: Boolean = false
while (input.hasNext) {
val row = input.next().asInstanceOf[UnsafeRow]
numFields = row.numFields()
val key = keyGenerator(row)
- if (!key.anyNull) {
+ if ((0 until numKeys).forall(key.isNullAt)) {
+ allNullColumnKeyExistsInOriginInput = true
+ }
+
+ // TODO keep anyNull key for multi column NAAJ support in future
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
