leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r460269289
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -923,9 +1006,9 @@ case class HashedRelationBroadcastMode(key:
Seq[Expression])
sizeHint: Option[Long]): HashedRelation = {
sizeHint match {
case Some(numRows) =>
- HashedRelation(rows, canonicalized.key, numRows.toInt)
+ HashedRelation(rows, canonicalized.key, numRows.toInt, isNullAware =
isNullAware)
Review comment:
there is still a taskMemoryManager: TaskMemoryManager = null (with
default value) just before isNullAware, I've had to using the named argument.
^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
