leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r460272135
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -896,22 +969,32 @@ private[joins] object LongHashedRelation {
// Create a mapping of key -> rows
var numFields = 0
+ val isOriginalInputEmpty: Boolean = !input.hasNext
+ var allNullColumnKeyExistsInOriginalInput: Boolean = false
while (input.hasNext) {
val unsafeRow = input.next().asInstanceOf[UnsafeRow]
numFields = unsafeRow.numFields()
val rowKey = keyGenerator(unsafeRow)
if (!rowKey.isNullAt(0)) {
+ // LongToUnsafeRowMap can't insert null key
val key = rowKey.getLong(0)
map.append(key, unsafeRow)
+ } else if (!allNullColumnKeyExistsInOriginalInput) {
Review comment:
because LongHashedRelation can't insert null column key, that's why i
remove isNullAware from it.
in the HashedRelation case class comment, I define isNullAware as
```
If isNullAware is true, UnsafeHashedRelation will store rows with null keys.
```
I will update it if you think it's ok to still put isNullAware inside
LongHashedRelation after you have known about this information. ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
