abhishekd0907 commented on a change in pull request #29242:
URL: https://github.com/apache/spark/pull/29242#discussion_r460557453
##########
File path: python/pyspark/sql/dataframe.py
##########
@@ -674,7 +674,7 @@ def cache(self):
.. note:: The default storage level has changed to `MEMORY_AND_DISK`
to match Scala in 2.0.
"""
self.is_cached = True
- self._jdf.cache()
+ self.persist(StorageLevel.MEMORY_AND_DISK)
Review comment:
On scala side, default is `StorageLevel(true, true, false, true)` which
has `deserialized=true`. It is getting used when scala `cache()` method is
called directly as in the case with the current master branch.
However, since the data is already serialized on the Python side, Storage
level to be used should have `deserialized=false`. With this code change
persist will be called with `StorageLevel(True, True, False, False)` and hence
deserialized will be set to false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
