leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r460805760
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JoinSuite.scala
##########
@@ -1147,4 +1147,40 @@ class JoinSuite extends QueryTest with
SharedSparkSession with AdaptiveSparkPlan
})
}
}
+
+ test("SPARK-32290: SingleColumn Null Aware Anti Join Optimize") {
+ withSQLConf(SQLConf.NULL_AWARE_ANTI_JOIN_OPTIMIZE_ENABLED.key -> "true",
+ SQLConf.AUTO_BROADCASTJOIN_THRESHOLD.key -> Long.MaxValue.toString) {
Review comment:
kind of need broadcastThreshold config
or the following case will planed into SMJ
```
// negative hand-written left anti join
// testData.key nullable false
// testData2.a nullable false
joinExec = assertJoin((
"select * from testData left anti join testData2 ON key = a or
isnull(key = a)",
classOf[BroadcastHashJoinExec]))
assert(!joinExec.asInstanceOf[BroadcastHashJoinExec].isNullAwareAntiJoin)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
