leanken commented on a change in pull request #29104:
URL: https://github.com/apache/spark/pull/29104#discussion_r460772228
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -311,6 +314,15 @@ private[joins] object UnsafeHashedRelation {
key: Seq[Expression],
sizeEstimate: Int,
taskMemoryManager: TaskMemoryManager): HashedRelation = {
+ apply(input, key, sizeEstimate, taskMemoryManager, isNullAware = false)
+ }
+
+ def apply(
+ input: Iterator[InternalRow],
+ key: Seq[Expression],
+ sizeEstimate: Int,
+ taskMemoryManager: TaskMemoryManager,
+ isNullAware: Boolean = false): HashedRelation = {
Review comment:
let me remove them and see if there are build issues. if not , I will
remove them for good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
