Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/5139#discussion_r27357055
--- Diff:
core/src/main/scala/org/apache/spark/mapred/SparkHadoopMapRedUtil.scala ---
@@ -65,3 +71,77 @@ trait SparkHadoopMapRedUtil {
}
}
}
+
+object SparkHadoopMapRedUtil extends Logging {
+ def commitTask(
+ committer: MapReduceOutputCommitter,
+ mrTaskContext: MapReduceTaskAttemptContext,
+ sparkTaskContext: TaskContext): Unit = {
+ commitTask(
+ committer,
+ mrTaskContext,
+ sparkTaskContext.stageId(),
+ sparkTaskContext.partitionId(),
+ sparkTaskContext.attemptNumber())
+ }
+
+ def commitTask(
--- End diff --
Please add documentation to this guy mentioning what it means to commitTask
(i.e., we may contact the driver to become authorized to commit to ensure
speculative tasks do not override each other, and that this may cause us to
abort the task by throwing a CommitDeniedException if we cannot become
authorized as such), pointing to the JIRA that this fixes (the original one).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
