Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/5139#issuecomment-87846414
LGTM from a Spark core point-of-view. One of the biggest risks here is
passing the Long-valued parameters in the wrong order, but it looks like we've
done it correctly here. I suppose that another risk might be calling the
commit function with values of jobId, splitId, and attemptId that don't match /
correspond to the ones used in the MapReduceTaskAttemptContext (that would
undermine the whole scheme because the coordination wouldn't necessarily be
guarding the right output paths), but our usage here looks fine as far as I can
tell.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
