tgravescs commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r462334961
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
def canFetchMoreResults(size: Long): Boolean = sched.synchronized {
totalResultSize += size
calculatedTasks += 1
- if (maxResultSize > 0 && totalResultSize > maxResultSize) {
+ if (!isShuffleMapTasks && maxResultSize > 0 && totalResultSize >
maxResultSize) {
Review comment:
yes this seems reasonable. It would be nice to update the comment on
the function as well as put description in jira and in this PR to include more
details about the shuffle map status and I assume you actually his this case in
an application.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
