cloud-fan commented on a change in pull request #29276:
URL: https://github.com/apache/spark/pull/29276#discussion_r463059544
##########
File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
##########
@@ -695,7 +696,7 @@ private[spark] class TaskSetManager(
def canFetchMoreResults(size: Long): Boolean = sched.synchronized {
totalResultSize += size
calculatedTasks += 1
- if (maxResultSize > 0 && totalResultSize > maxResultSize) {
+ if (!isShuffleMapTasks && maxResultSize > 0 && totalResultSize >
maxResultSize) {
Review comment:
> But seems we will save the MapStatus in MapOutputTracker. Don't we?
We do, but it's a global thing. Limiting the total size of one stage doesn't
help too much. I believe the check here was to prevent too much data in
`rdd.collect`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
