Github user ilganeli commented on the pull request:
https://github.com/apache/spark/pull/5236#issuecomment-87457182
Sean - there's actually only one variable that is still labeled as Ms. All
the other ones don't include units in the parameter name.
On Sun, Mar 29, 2015 at 4:11 AM Sean Owen <[email protected]> wrote:
> Yeah, the issue is changing the property names, not adding to the values
> they can take on. I think that's a decent idea myself, to be able to
> specify "100s" instead of "100000" for a millisecond property.
>
> It raises interesting questions. Is it weird to see foo.bar.timeoutMS =
> 100s ? Of course, that's the reason for changing the property name, but
> then that itself is disruptive. Also, now you could specify
foo.bar.intervalSec
> = 1ms whereas it would not have been possible before to specify an
> interval below 1 second. I suspect that will be OK, with code changes, but
> bears verifying.
>
> I swear there was another PR for just this, but I can't find it for the
> life of me.
>
> This is one where I'd appeal to others for an opinion.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/5236#issuecomment-87395279>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
