skambha commented on pull request #29125: URL: https://github.com/apache/spark/pull/29125#issuecomment-667336119
@cloud-fan, I noticed this back port only now. This change is more far reaching in its impact as previous callers of UnsafeRow.getDecimal that would have thrown an exception earlier would now return null. As an e.g, a caller like aggregate sum will need changes to account for this. Earlier cases where sum would throw error for overflow will **now return incorrect results**. The new tests that were added for sum overflow cases in the DataFrameSuite in master can be used to see repro. Since this pr is closed, I will add a comment to the JIRA as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
