cloud-fan commented on a change in pull request #28527:
URL: https://github.com/apache/spark/pull/28527#discussion_r464195071
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -350,6 +358,16 @@ class SessionCatalog(
}
}
+ private def makeQualifiedTablePath(locationUri: URI, database: String): URI
= {
+ if (locationUri.isAbsolute) {
+ locationUri
+ } else {
+ val dbName = formatDatabaseName(database)
+ val dbLocation =
makeQualifiedDBPath(getDatabaseMetadata(dbName).locationUri)
Review comment:
I'm a bit concerned about it as it adds an extra database lookup. Is it
better to push this work to the underlying external catalog?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
