cloud-fan commented on a change in pull request #28527:
URL: https://github.com/apache/spark/pull/28527#discussion_r464317338
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -350,6 +358,16 @@ class SessionCatalog(
}
}
+ private def makeQualifiedTablePath(locationUri: URI, database: String): URI
= {
+ if (locationUri.isAbsolute) {
+ locationUri
+ } else {
+ val dbName = formatDatabaseName(database)
+ val dbLocation =
makeQualifiedDBPath(getDatabaseMetadata(dbName).locationUri)
Review comment:
Ideally `createTable` should only do one RPC to the hive metastore.
`requireDbExists` is one problem but we can simply remove it. However, the new
database lookup seems can't be easily removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
