tgravescs commented on a change in pull request #28939:
URL: https://github.com/apache/spark/pull/28939#discussion_r467959610
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2598,6 +2598,15 @@ private[spark] object Utils extends Logging {
conf.get(JARS).filter(_.nonEmpty)
}
+ /**
+ * Return the files pointed by the "spark.files" property. Spark internally
will distribute
+ * these files through file server. In the YARN mode, it will return an
empty list, since YARN
+ * has its own mechanism to distribute files.
+ */
+ def getUserFiles(conf: SparkConf): Seq[String] = {
Review comment:
this is unused?
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -220,6 +220,21 @@ private[spark] class Executor(
heartbeater.start()
+ private val appStartTime = conf.getLong("spark.app.startTime", 0)
+
+ // Jars and files specified by spark.jars and spark.files.
Review comment:
it would be nice to expand these comment stating why we do this
specially and it has to be before the plugins run
##########
File path: core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala
##########
@@ -1220,6 +1221,87 @@ class SparkSubmitSuite
testRemoteResources(enableHttpFs = true, forceDownloadSchemes = Seq("*"))
}
+
Review comment:
nit remove extra newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
