dongjoon-hyun commented on a change in pull request #29331:
URL: https://github.com/apache/spark/pull/29331#discussion_r467963886
##########
File path: core/src/test/scala/org/apache/spark/DistributedSuite.scala
##########
@@ -206,7 +206,8 @@ class DistributedSuite extends SparkFunSuite with Matchers
with LocalSparkContex
"caching on disk" -> StorageLevel.DISK_ONLY,
"caching in memory, replicated" -> StorageLevel.MEMORY_ONLY_2,
"caching in memory, serialized, replicated" ->
StorageLevel.MEMORY_ONLY_SER_2,
- "caching on disk, replicated" -> StorageLevel.DISK_ONLY_2,
+ "caching on disk, replicated 2" -> StorageLevel.DISK_ONLY_2,
+ "caching on disk, replicated 3" -> StorageLevel.DISK_ONLY_3,
Review comment:
> so what happen if there aren't 3 executors?
The number of copies becomes 2 and this test case fail reasonably.
> do we have a test that needs updating?
Yes. This test suite is updated at line 41.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
