cloud-fan commented on a change in pull request #29389:
URL: https://github.com/apache/spark/pull/29389#discussion_r468038934
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashJoin.scala
##########
@@ -29,6 +29,16 @@ import org.apache.spark.sql.execution.{CodegenSupport,
ExplainUtils, RowIterator
import org.apache.spark.sql.execution.metric.SQLMetric
import org.apache.spark.sql.types.{BooleanType, IntegralType, LongType}
+/**
+ * @param relationTerm variable name for HashedRelation
+ * @param keyIsUnique indicate whether keys of HashedRelation known to be
unique in code-gen time
+ * @param isEmptyHashedRelation indicate whether it known to be
EmptyHashedRelation in code-gen time
+ */
+private[joins] case class HashedRelationInfo(
+ relationTerm: String,
+ keyIsUnique: Boolean,
+ isEmptyHashedRelation: Boolean)
Review comment:
we can probably make the name shorter, just use `isEmpty`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
