cloud-fan commented on a change in pull request #29389:
URL: https://github.com/apache/spark/pull/29389#discussion_r468039532
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/ShuffledHashJoinExec.scala
##########
@@ -81,13 +81,13 @@ case class ShuffledHashJoinExec(
override def needCopyResult: Boolean = true
- protected override def prepareRelation(ctx: CodegenContext): (String,
Boolean) = {
+ protected override def prepareRelation(ctx: CodegenContext):
HashedRelationInfo = {
val thisPlan = ctx.addReferenceObj("plan", this)
val clsName = classOf[HashedRelation].getName
// Inline mutable state since not many join operations in a task
val relationTerm = ctx.addMutableState(clsName, "relation",
v => s"$v = $thisPlan.buildHashedRelation(inputs[1]);", forceInline =
true)
- (relationTerm, false)
+ HashedRelationInfo(relationTerm, false, false)
Review comment:
nit: `...(..., isKeyUnique = false, isEmpty = false)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
