Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5115#discussion_r27515621
--- Diff: core/src/main/scala/org/apache/spark/HttpServer.scala ---
@@ -160,7 +163,8 @@ private[spark] class HttpServer(
throw new ServerStateException("Server is not started")
} else {
val scheme = if (securityManager.fileServerSSLOptions.enabled)
"https" else "http"
- s"$scheme://${Utils.localIpAddress}:$port"
+ val hosturi =
InetAddresses.toUriString(InetAddress.getByName(localHostname))
+ s"$scheme://${InetAddresses.toUriString(hosturi)}:$port"
--- End diff --
Now `toUriString` is called twice -- the string should just refer to
`${hosturi}`.
While we're doing another last pass, two more tiny nits: `hostUri` instead
of `hosturi` at least, and, there is a spurious blank line added in the other
file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
