Github user vlyubin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5279#discussion_r27512459
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/basicOperators.scala ---
    @@ -140,8 +140,11 @@ case class TakeOrdered(limit: Int, sortOrder: 
Seq[SortOrder], child: SparkPlan)
       private def collectData(): Array[Row] = 
child.execute().map(_.copy()).takeOrdered(limit)(ord)
     
       // TODO: Is this copying for no reason?
    --- End diff --
    
    It wasn't relevant before the change as well (that copy call wasn't there 
anymore). I'll remove it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to